Fix pushing keyboard and mouse to the same stack level#2636
Merged
einarf merged 1 commit intopythonarcade:developmentfrom Apr 2, 2025
Merged
Fix pushing keyboard and mouse to the same stack level#2636einarf merged 1 commit intopythonarcade:developmentfrom
einarf merged 1 commit intopythonarcade:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The push_handlers function is used incorrectly. It only pushes a single stack level, meaning mouse and keyboard override each other. This means, their shared events, such as on_deactivate, will only be triggered by the last option, which is mouse here. This causes the keyboard to ignore the on_deactivate event. This fixes that issue by pushing 2 times to different levels.