Skip to content

Make adjusted hitbox points ~35% faster #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
einarf merged 1 commit into from
Mar 28, 2025
+14 −9
Merged

Make adjusted hitbox points ~35% faster #2626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions arcade/hitbox/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,15 +230,18 @@ def get_adjusted_points(self) -> Point2List:
if not self._adjusted_cache_dirty:
return self._adjusted_points # type: ignore

position_x, position_y = self._position
scale_x, scale_y = self._scale

def _adjust_point(point) -> Point2:
x, y = point

x *= self.scale[0]
y *= self.scale[1]
x *= scale_x
y *= scale_y

return (x + self.position[0], y + self.position[1])
return (x + position_x, y + position_y)

self._adjusted_points = [_adjust_point(point) for point in self.points]
self._adjusted_points = [_adjust_point(point) for point in self._points]
self._adjusted_cache_dirty = False
return self._adjusted_points

Expand Down Expand Up @@ -295,14 +298,16 @@ def get_adjusted_points(self) -> Point2List:
return self._adjusted_points

rad = radians(-self._angle)
scale_x, scale_y = self._scale
position_x, position_y = self._position
rad_cos = cos(rad)
rad_sin = sin(rad)

def _adjust_point(point) -> Point2:
x, y = point

x *= self.scale[0]
y *= self.scale[1]
x *= scale_x
y *= scale_y

if rad:
rot_x = x * rad_cos - y * rad_sin
Expand All @@ -311,10 +316,10 @@ def _adjust_point(point) -> Point2:
y = rot_y

return (
x + self.position[0],
y + self.position[1],
x + position_x,
y + position_y,
)

self._adjusted_points = [_adjust_point(point) for point in self.points]
self._adjusted_points = [_adjust_point(point) for point in self._points]
self._adjusted_cache_dirty = False
return self._adjusted_points
Loading