Update application.py#2526
Conversation
fixes type hinting to match the returned properties fixes pythonarcade#2525
pushfoo
left a comment
There was a problem hiding this comment.
Although it may seem counter-intuitive, the float option may be more correct:
- Mac uses float pairs for their screen locations (example)
- Other platforms may as well
This affects future mobile and web support plans as well, but it's a long-standing issue which affects pyglet.
Personally, I just want my type checker to chill out; I don't care which is more correct. If float is the more correct one, then should we change the I'm getting the following from pylance: And it is complaining about the following code:
This is a view attempting to create a section that is the same size as itself, but Pylance is unhappy that the types don't match. |
|
Could we just allow float or int, both would work right? |
|
That would solve my personal issue with it (type checking), and if it works for the technical side too I'm all for it. |
|
I'm going to open a new pull request with changes to |
fixes type hinting to match the returned properties
fixes #2525