re.findall specific types str | bytes

[relikd]

I hope I am not missing something important, but shouldn't these types be specific?

[srittau]

The problem is that findall returns either a list[X] or a list[tuple[X, ...]] where X is either str or bytes, depending on the pattern. Since unions in return types are problematic in cases like this (see also python/typing#566 for a possible solution), list[Any] is the best we can do.

That said, I think we could improve this comment to make this more clear:

Suggested change

	# return type depends on the number of groups in the pattern
	# return type is either list[str/bytes] or list[tuple[str/bytes, ...]]
	# depending on the number of groups in the pattern

We also should copy this comment to the other findall group below.

[relikd]

thank you, I removed my suggested change and added the comments

[github-actions]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉