[behave] Added anottations for four classes#15953
Open
Spider84pr wants to merge 3 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
Spider84pr
changed the title
Contributor
Author
|
I have added remaining annotation as much as can. |
This comment has been minimized.
This comment has been minimized.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
sobolevn
reviewed
Jun 28, 2026
| def execute_steps(self, steps_text: str) -> bool: ... | ||
| def add_cleanup(self, cleanup_func: Callable[_P, Incomplete], *args: _P.args, **kwargs: _P.kwargs) -> None: ... | ||
| @property | ||
| def captured(self): ... |
| @staticmethod | ||
| def ignore_cleanup_error(context, cleanup_func, exception: BaseException) -> None: ... | ||
| def use_with_user_mode(self) -> AbstractContextManager[None]: ... | ||
| def user_mode(self) -> Generator[Incomplete]: ... |
Member
There was a problem hiding this comment.
If we are refactoring this module, let's remove all Incomplete types as well. Or add a comment on why it is hard to do / impossible (if this is the case).
Contributor
Author
There was a problem hiding this comment.
@sobolevn I have already mentioned that this library missing most of classes stubs. When I create it I will update this file too.
| def attach(self, mime_type: str, data: bytes) -> None: ... | ||
|
|
||
| @contextlib.contextmanager | ||
| def use_context_with_mode(context, mode) -> Generator[None]: ... |
Member
There was a problem hiding this comment.
When adding new annotations, it would be preferable to add types to them :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on fully annotating behave/behave/runner.pyi.
This first commit adds annotations for four classes (ModelRunner, Runner, ContextMaskWarning, ContextMode).
In the next commit I'll add the remaining annotations (standalone functions and the Context class, which was partially annotated before).