Use PYODIDE environment variable for Emscripten cross-compilation detection#21714
Merged
Merged
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I noticed that y'all were carrying this workaround ever since #14888. A better way to detect this is through the
PYODIDEenvironment variable, which we've documented over the years, and is what most projects use now. The MACHDEP generality would mostly apply to non-Pyodide-specific WASM build targets, which are growing in relevance but are a bit less mature as Pyodide at this time.Also, thank you for adopting PEP 783 and publishing pyemscripten wheels for mypy – we're pretty happy about it!