Speed up transitive_dep_hash for singleton SCCs#21390
Merged
Merged
Conversation
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JukkaL
approved these changes
May 22, 2026
JukkaL
left a comment
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
This adds some duplication, but a 1% perf improvement makes it worth it.
KevinRK29
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed on a large codebase ~99.84% of SCCs are singletons.
So the two main changes are adding a singleton fast path and extracting
graph[id]to be a local variable so that it does the lookup once per module rather than once per dependency,The time in the
transitive_dep_hashfunction drops 22%, and improved the overall warm run by 1%