Skip to content

gh-162141: Use const STACK_OF(SSL_CIPHER)* for SSL_get_ciphers - #162143

Open
chlily1 wants to merge 1 commit into
python:mainfrom
chlily1:get_ciphers_const
Open

chlily1 wants to merge 1 commit into
python:mainfrom
chlily1:get_ciphers_const

Conversation

@chlily1

@chlily1 chlily1 commented Nov 16, 2026 •

Copy link
Copy Markdown

const-correct two local variables: they are only read via sk_SSL_CIPHER_num() and sk_SSL_CIPHER_value(), which take a const stack, so this is a no-op for existing builds. Also matches BoringSSL's planned change to return const STACK_OF(SSL_CIPHER)* from SSL_get_ciphers() and SSL_CTX_get_ciphers() (https://crbug.com/550501994).

const-correct two local variables: they are only read via
sk_SSL_CIPHER_num() and sk_SSL_CIPHER_value(), which take a const stack,
so this is a no-op for existing builds. Also matches BoringSSL's planned
change to return const STACK_OF(SSL_CIPHER)* from SSL_get_ciphers() and
SSL_CTX_get_ciphers() (https://crbug.com/550501994).
@python-cla-bot

python-cla-bot Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

bedevere-app Bot commented Nov 16, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@chlily1

chlily1 commented Nov 16, 2026

Copy link
Copy Markdown
Author

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

This is probably skip news.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant