Skip to content

gh-145633: Allow PyFloat_Pack8 & PyFloat_UnPack* to fail in future CPython versions#153440

Merged
encukou merged 1 commit into
python:mainfrom
encukou:fallible-pyfloat-pack
Jul 10, 2026
Merged

gh-145633: Allow PyFloat_Pack8 & PyFloat_UnPack* to fail in future CPython versions#153440
encukou merged 1 commit into
python:mainfrom
encukou:fallible-pyfloat-pack

Conversation

@encukou

@encukou encukou commented Jul 9, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@encukou encukou requested a review from ZeroIntensity as a code owner July 9, 2026 14:50
@bedevere-app bedevere-app Bot added the docs Documentation in the Doc dir label Jul 9, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Jul 9, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jul 9, 2026
Closed
@read-the-docs-community

read-the-docs-community Bot commented Jul 9, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33515882 | 📁 Comparing c7b0f2c against main (dd8739a)

  🔍 Preview build  

2 files changed
± c-api/float.html
± whatsnew/changelog.html

@encukou encukou mentioned this pull request Jul 9, 2026
Closed
vstinner
vstinner approved these changes Jul 9, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner vstinner added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 9, 2026
@vstinner

vstinner commented Jul 9, 2026

Copy link
Copy Markdown
Member

The Python 3.15 also contains this "implementation detail", so it should also be removed: https://docs.python.org/3.15/c-api/float.html#c.PyFloat_Pack8.

@encukou encukou merged commit 9324f84 into python:main Jul 10, 2026
41 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jul 10, 2026
@encukou encukou deleted the fallible-pyfloat-pack branch July 10, 2026 08:35
@miss-islington-app

miss-islington-app Bot commented Jul 10, 2026

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jul 10, 2026

Copy link
Copy Markdown

GH-153490 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 10, 2026
vstinner pushed a commit that referenced this pull request Jul 10, 2026
@miss-islington @encukou
[3.15] gh-145633: Allow PyFloat_Pack8 & PyFloat_UnPack* to fail in fu…
45a769f 
…ture CPython versions (GH-153440) (#153490)

gh-145633: Allow PyFloat_Pack8 & PyFloat_UnPack* to fail in future CPython versions (GH-153440)
(cherry picked from commit 9324f84)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@encukou @vstinner