[3.15] gh-153422: Assert bool return type in tkinter tests (GH-153429)#153439
Merged
serhiy-storchaka merged 1 commit intoJul 9, 2026
Merged
Conversation
…honGH-153429) The tests for PhotoImage.transparency_get(), Text.debug() and Treeview.exists() now assert the exact bool type, and the documentation and docstrings use "true"/"false" instead of "1"/"0". Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
added
needs backport to 3.13
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
|
GH-153442 is a backport of this pull request to the 3.14 branch. |
|
GH-153443 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 9, 2026
GH-153439) (GH-153442) The tests for PhotoImage.transparency_get(), Text.debug() and Treeview.exists() now assert the exact bool type, and the documentation and docstrings use "true"/"false" instead of "1"/"0". (cherry picked from commit 1604c80) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 10, 2026
GH-153439) (GH-153443) The tests for PhotoImage.transparency_get(), Text.debug() and Treeview.exists() now assert the exact bool type, and the documentation and docstrings use "true"/"false" instead of "1"/"0". (cherry picked from commit 1604c80) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial backport of #153429 (gh-153422) to 3.15, without the behavior change:
winfo_exists(),winfo_ismapped(),winfo_viewable()andText.edit_modified()continue to return an integer on 3.15, so only the version-independent parts are backported.The tests for
PhotoImage.transparency_get(),Text.debug()andTreeview.exists()— which already return aboolon all versions — now assert the exact type withassertIs.The documentation for the
winfo_*methods andText.edit_modified()uses general lowercasetrue/falseinstead of1/0(their return type is unchanged here), whileTreeview.tag_has()'s docstring usesTrue/False, since it genuinely returns abool.🤖 Generated with Claude Code