gh-118860: docs: clarify custom build output directory in PCbuild/readme.txt#153382
Open
pranavchoudhary-tech wants to merge 4 commits into
Open
gh-118860: docs: clarify custom build output directory in PCbuild/readme.txt#153382pranavchoudhary-tech wants to merge 4 commits into
pranavchoudhary-tech wants to merge 4 commits into
Conversation
pranavchoudhary-tech
changed the title
pranavchoudhary-tech
force-pushed
the
docs-py-outdir
branch
from
d769fc1 to
f97713d
Compare
zooba
reviewed
Jul 9, 2026
pranavchoudhary-tech
force-pushed
the
docs-py-outdir
branch
from
408c98f to
1f573ad
Compare
Member
|
Please don't force push. We always squash merge and rewrite commit messages at the end, so the history won't be in the repository. All that force pushing achieves is to break incremental reviews - we now have to re-read your entire contribution and guess what has changed, rather than being able to see the difference from recent commits. This will slow down our review. |
Contributor
Author
|
@zooba Understood! I'll avoid force-pushing and just append new commits for any future changes to preserve the incremental review history. Thanks for pointing that out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118860. This PR adds a small section to
PCbuild/readme.txtclarifying the use ofPy_OutDirfor custom output directories andPC/layoutfor creating install-shaped layouts, as suggested by the maintainers in the issue thread.