-
-
Notifications
You must be signed in to change notification settings - Fork 35k
gh-152384: pixi-packages: use flags to define variants
#152385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
8b5b0c2
81c8972
b226f35
5cba45c
f152ba7
18c12e6
44c27db
a608b30
8af45b3
2b05522
01a12c8
08807bb
330239c
036f9a3
d72075b
de788e8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| The CPython Pixi packages are now all accessible at the same | ||
| ``Tools/pixi-packages`` subdirectory, rather than at | ||
| ``Tools/pixi-packages/{variant}`` as before. Variants are now selected not | ||
| via subdirectory but via ``flags``; see | ||
| https://pixi.prefix.dev/latest/concepts/package_specifications/#extras-and-flags | ||
| for usage instructions. The ``tsan-freethreading`` variant has been renamed | ||
| to ``tsan_freethreading``, while the ``default``, ``asan``, and | ||
| ``freethreading`` variants retain their previous names. |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,9 @@ | ||
| # NOTE: Please always only modify default/pixi.toml and then run clone-recipe.sh to | ||
| # propagate the changes to the other variants. | ||
|
|
||
| [workspace] | ||
| channels = ["https://prefix.dev/conda-forge"] | ||
| platforms = ["linux-64", "linux-aarch64", "osx-64", "osx-arm64"] | ||
| preview = ["pixi-build"] | ||
| requires-pixi = ">=0.66.0" | ||
| requires-pixi = ">=0.72.2" | ||
|
|
||
| [package.build.backend] | ||
| name = "pixi-build-rattler-build" | ||
| version = "*" | ||
|
|
||
| [package.build.config] | ||
| recipe = "../default/recipe.yaml" |
This file was deleted.
This file was deleted.
|
lucascolley marked this conversation as resolved.
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| version: ["3.16"] | ||
| variant: ["default", "asan", "freethreading", "tsan_freethreading"] | ||
|
|
||
| openssl: | ||
| - '3.5' | ||
|
|
||
| # match `.github/workflows/reusable-san.yml` | ||
| c_compiler: | ||
| - clang | ||
| c_compiler_version: | ||
| - 21 | ||
| cxx_compiler: | ||
| - clangxx | ||
| cxx_compiler_version: | ||
| - 21 | ||
|
Comment on lines
+4
to
+15
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we add comments explaining these pin choices?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @kumaraditya303 how would you explain when these need to be updated, and where to look for the new versions?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Who suggested it, and was it for to avoid a bug in newer clang, for reproducibility, or for building the JIT in the future (that needs LLVM 21, but the JIT isn't covered by the build variants today, and I'd think any recent version should work for default/free-threaded/asan/tsan builds)?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Ideally it should match the version of clang used in https://github.com/python/cpython/blob/main/.github/workflows/reusable-san.yml, so if that file is updated pixi definitions should be updated as well.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is there some kind of policy for when this is updated, or somewhere where the current target is documented?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think if you just add a comment in the other file that the pixi packages need to be updated with a pointer to what exactly needs to be updated at the same time then that should be sufficient |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to remove the
-from this variant name, given that it is invalid in theflagsfield: https://conda.org/learn/ceps/cep-0045#repodata-record-syntaxThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine to me, I think you and @crusaderky are just about the only users of these builds so far for what its worth