gh-150452: use PyMutex in socket module#150453
Merged
kumaraditya303 merged 4 commits intoJul 15, 2026
Merged
Conversation
Contributor
|
The change is not user-facing, news isn't needed. This PR alone is sufficient, you can close the other one and I'll backport this. |
vstinner
reviewed
May 28, 2026
vstinner
reviewed
Jun 1, 2026
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
Can you please fix the merge conflict?
KowalskiThomas
force-pushed
the
kowalski/refactor-use-pymutex-in-socket-module
branch
from
15788c0 to
98b12b7
Compare
Contributor
Author
|
@vstinner rebased and fixed the merge conflict from my other PR |
Contributor
|
There are merge conflicts. |
Co-authored-by: Victor Stinner <vstinner@python.org>
KowalskiThomas
force-pushed
the
kowalski/refactor-use-pymutex-in-socket-module
branch
from
98b12b7 to
83dd464
Compare
Contributor
Author
|
@kumaraditya303 just had a look, error handling for I had to rebase (instead of merge main into my branch) because Git would complain about merging "unrelated histories" -- I've never seen that before so I'm not sure what happened there. Anyway, should be good now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #150452.
socketmodule should usePyMutexinstead of Lock #150452