Repository navigation
Add hover tooltips to theme controls - #21
Merged
Merged
Conversation
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
=======================================
Coverage 94.25% 94.25%
=======================================
Files 8 8
Lines 609 609
Branches 73 73
=======================================
Hits 574 574
Misses 14 14
Partials 21 21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The GitHub button and several other controls have accessible labels but no hover text. Add native
titletooltips to Fuma's buttons, section selectors, navigation links, LLM menu entries, pagination, and page actions. Icon buttons use the same text for their tooltip and accessible label.Update existing markup assertions for the added attributes. No new tests or version bump needed for this template change.
make lintand all 114 tests pass. Browser checks covered desktop and mobile in both docs and notebook layouts: all 28 rendered controls have nonempty titles, icon labels match their titles, and sidebar toggles and dropdowns still work.Type of Change
Checklist
make lint)make test)