Skip to content

Fix contributing guide label links#10913

Merged
radoering merged 2 commits into
python-poetry:mainfrom
Mirochill:docs-10765-label-links
May 23, 2026
Merged

Fix contributing guide label links#10913
radoering merged 2 commits into
python-poetry:mainfrom
Mirochill:docs-10765-label-links

Conversation

@Mirochill
Copy link
Copy Markdown
Contributor

@Mirochill Mirochill commented May 19, 2026

Summary

Fix the contributing guide links for the kind/question and area/docs GitHub labels.

The label names contain /, so the label URLs need %2F encoding. The kind/question link is kept inline inside the note shortcode so the generated website can render it correctly.

Fixes #10765.

Validation

  • git diff --check HEAD~1..HEAD
  • GitHub API metadata checked for kind%2Fquestion and area%2Fdocs
  • Remote checks green on af9f0b1: Detect changed files, Status, Tests / FreeBSD Status, pre-commit.ci - pr, and Sourcery review
  • Full test matrix skipped as docs-only; Documentation Preview skipped on the follow-up push

@Mirochill Mirochill marked this pull request as ready for review May 19, 2026 19:31
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@radoering radoering force-pushed the docs-10765-label-links branch from f131762 to 442ee54 Compare May 23, 2026 05:24
@radoering radoering added the impact/docs Contains or requires documentation changes label May 23, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 23, 2026

Deploy preview for website ready!

Project:website
Status: ✅  Deploy successful!
Preview URL:https://website-rdkj03fau-python-poetry.vercel.app
Latest Commit:af9f0b1

Deployed with vercel-action

@radoering radoering removed the impact/docs Contains or requires documentation changes label May 23, 2026
Copy link
Copy Markdown
Member

@radoering radoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem to work. See the generated preview. Maybe, the link targets have to be inline in notes. 🤷 By the way, you can also build the docs locally with the website repo.

@Mirochill
Copy link
Copy Markdown
Contributor Author

Thanks, fixed in af9f0b1 by keeping the links inside the note inline and only encoding the label slash in the GitHub URL.

The latest published checks are green: Detect changed files, Status, pre-commit.ci, Sourcery review, and FreeBSD. The Documentation Preview job was skipped on this follow-up push, so I do not have a refreshed preview URL to cite.

@radoering radoering added the impact/docs Contains or requires documentation changes label May 23, 2026
@radoering radoering merged commit 4bc8907 into python-poetry:main May 23, 2026
57 checks passed
@radoering radoering removed the impact/docs Contains or requires documentation changes label May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation: broken link

2 participants