Fix AttributeError: __metadata__ on Python 3.13#304
Merged
davidparsson merged 1 commit intopython-injector:masterfrom Jan 9, 2026
Merged
Conversation
Collaborator
|
Thanks for your contribution! Would you be able to include a test that exposes the problem? The test suite passed on 3.13 before this change. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #304 +/- ##
=======================================
Coverage 96.54% 96.54%
=======================================
Files 1 1
Lines 608 608
Branches 103 103
=======================================
Hits 587 587
Misses 15 15
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Oh, I saw your issue just now. I can add a test myself based on that. Thanks again! |
Collaborator
|
Fixes #303 |
Collaborator
|
This is released in 0.24.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a breaking AttributeError:
__metadata__encountered when running injector on Python 3.13.In Python 3.13, certain type hints (particularly those involving
Literal,Union, or classes usingslots=True) can be identified as a specialization ofAnnotatedbut do not consistently expose the__metadata__attribute. Direct access tov.__metadata__now raises anAttributeErrorin these scenarios, whereas in previous Python versions it would typically return an empty tuple or simply not be triggered in this specific code path.Changes
Modified the
has_injectable_parameterscheck ininjector/__init__.pyto usegetattr()when accessing__metadata__.This ensures that if the attribute is missing, the code defaults to an empty tuple, allowing the
incheck to fail gracefully instead of raising an exception.