feat(config): replace TypedDict options with Hook*Configuration - #704
Open
RonnyPfannschmidt wants to merge 3 commits into
Open
feat(config): replace TypedDict options with Hook*Configuration#704RonnyPfannschmidt wants to merge 3 commits into
RonnyPfannschmidt wants to merge 3 commits into
Conversation
RonnyPfannschmidt
force-pushed
the
refactor/configuration-objects
branch
from
July 24, 2026 16:53
65ee170 to
6993f10
Compare
RonnyPfannschmidt
force-pushed
the
refactor/configuration-objects
branch
3 times, most recently
from
August 12, 2026 11:14
ad3a5a9 to
eef72c1
Compare
This was referenced Aug 12, 2026
Open
RonnyPfannschmidt
marked this pull request as ready for review
September 12, 2026 14:29
Add the design/ writeup chain (decisions + per-step docs 01-07) that guides the stacked refactoring branches. Exclude design/ from blacken-docs since the docs use elided pseudo-code signatures. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
RonnyPfannschmidt
force-pushed
the
refactor/configuration-objects
branch
from
September 12, 2026 19:04
eef72c1 to
01d2977
Compare
Move hook types, markers, callers, implementations, and multicall out of the monolithic _hooks/_callers modules so later typed-config and CompletionHook work can land without thrashing one huge file. Keep _hooks and _callers as re-export shims for import compatibility. Co-authored-by: Cursor AI <ai@cursor.sh> Co-authored-by: Cursor Grok 4.5 <grok@cursor.com>
Markers attach HookspecConfiguration/HookimplConfiguration objects. Registration discovers those privately; parse_hookimpl_opts and parse_hookspec_opts remain a deprecated pytest concession that returns legacy dicts and is only called when a subclass overrides them and no modern configuration attribute was found. Co-authored-by: Cursor AI <ai@cursor.sh> Co-authored-by: Cursor Grok 4.5 <grok@cursor.com>
RonnyPfannschmidt
force-pushed
the
refactor/configuration-objects
branch
from
September 12, 2026 19:14
01d2977 to
80420c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge PR — step 2 of 7.
This PR targets
main, so GitHub shows the cumulative diff of steps 1–2. For this step's isolated diff, use the downstream review PR RonnyPfannschmidt#5, which targets the previous step's branch.Merge order is bottom-up: this one is ready once step 1 has landed.
refactor/split-hook-modulesrefactor/configuration-objectsrefactor/markers-attach-configrefactor/hookimpl-wrapper-typesrefactor/hookcaller-and-executionrefactor/project-specrefactor/async-submitterSummary
HookspecConfiguration/HookimplConfigurationparse_hook*_optsremains a deprecated pytest/support concession (dict return), only called when overridden and no modern config is presentReview
Incremental review against the module-split parent (preferred):
RonnyPfannschmidt#5
This upstream PR targets
mainand includes the module reorganization commit as well.Test plan
uv run pytestuv run pre-commit run -aMade with Cursor