Skip to content

refacto, add docker image and add role platform react#8

Merged
m-julio merged 2 commits intomainfrom
fix/clean-inventories
Mar 8, 2026
Merged

refacto, add docker image and add role platform react#8
m-julio merged 2 commits intomainfrom
fix/clean-inventories

Conversation

@m-julio
Copy link
Copy Markdown
Collaborator

@m-julio m-julio commented Dec 14, 2025

refacto 1 : rename vars files

  • /group_vars directory should be at the same level as /inventory
  • Files inside /group_vars directory should have the right extension (.yml)

refacto 2 : fix template inventories and simplify hosts

  • Fill inventory template with missing hosts : "annotation_server" and "mediamtx_server"
  • Delete hosts with suffix "-test" and "-prod" since it should be dealt with different inventories rather then different hosts
  • Use always the same naming for mediamtx (not "mediamtx_server" and "mediamtx" depending on the playbook)
  • Change name of inventory used in make file

Change: add dockerfile (and docker compose) to execute ansible commands

@m-julio m-julio force-pushed the fix/clean-inventories branch from 323f8f0 to faf2ef2 Compare December 14, 2025 10:26
@m-julio m-julio force-pushed the fix/clean-group-vars branch from ca9b6eb to 3d39f66 Compare December 17, 2025 07:23
@m-julio m-julio force-pushed the fix/clean-inventories branch from faf2ef2 to 2982d7b Compare December 17, 2025 07:28
@MateoLostanlen MateoLostanlen self-requested a review December 19, 2025 07:20
Copy link
Copy Markdown
Member

@MateoLostanlen MateoLostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @m-julio , thanks for the PR, it looks good to me. Have you tested it by merging all the PRs on both repositories? Worst case, we can merge and then make a fix PR afterward, that might be simpler

@m-julio m-julio force-pushed the fix/clean-inventories branch from 2982d7b to 724ccc8 Compare January 16, 2026 17:33
@m-julio m-julio changed the base branch from fix/clean-group-vars to main January 16, 2026 17:38
@m-julio m-julio force-pushed the fix/clean-inventories branch from 724ccc8 to aa42699 Compare January 16, 2026 17:43
@m-julio m-julio changed the title refacto: fix template inventories and simplify hosts (PR Refacto #2) refacto and add role platform react Jan 16, 2026
refacto on inventories
fix: clean group_vars directory and filename
@m-julio m-julio force-pushed the fix/clean-inventories branch from 8246df8 to e16ec9e Compare March 3, 2026 19:10
@m-julio m-julio changed the title refacto and add role platform react refacto, add docker image and add role platform react Mar 8, 2026
Copy link
Copy Markdown
Member

@fe51 fe51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to tag current version before merge.

@m-julio m-julio merged commit a9d29f7 into main Mar 8, 2026
@m-julio m-julio deleted the fix/clean-inventories branch March 22, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants