You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The new implementation of pyroscan.py did not properly handle runs that failed to reshape correctly, which can sometimes happen with large batches of runs. I believe that this gives more robust error handling.
Ah I see, When I change Pyroscan I ran into issues with how to handle creating a buffer is the first Pyro input file wasn't readable. This seems a good solution. My only request would be if you are able to create a test containing the original scenario that was failing. I wasn't aware of any good reason that you would have a pyroscan where the first item wasn't readable (hence the original error handling)
@FelixWattsYork , the failure state is unrelated to the pyroscan.py logic. In my case, it was related to the failure of cgyro.py to reshape the loaded gk_output data properly, likely due to a cluster-related IO failure. I am not really sure how to artificially manufacture such data, but more importantly, I don't think that falls under testing for pyroscan.py?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new implementation of
pyroscan.pydid not properly handle runs that failed to reshape correctly, which can sometimes happen with large batches of runs. I believe that this gives more robust error handling.