Open
Conversation
Conflicts: src/pyrokinetics/gk_code/gene.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This write a Yaml file that can be ingested by SimDB for a gyrokinetic database. This stores the following data in the yaml which should allow for a searchable database
Note the last two need to worked on. I have added a linear diagnostic
Convergencethat does a series of convergence tests for a linear sim, which are basically one useful number to describe something (like the field end ratios which show the ratio of a field at the end to its peak, the number should be small).Something simulation should be done for nonlinear simulations though that should be discussed (like standard deviation from average, peaks of spectra, grid scale oscillations). These should all eventually be added.
Further what GKOutput data should be added to this. Maybe time averages (or final time slice for linear) of
Many more could be added but the aim of this is for searchable data so we shouldn't go crazy.
@FelixWattsYork apparently I already added the jacobian into here for and forgot about it...
Note IDS is generated by
idspy-toolkitand notimaspyso we do need to switch over at some point!