Repository navigation
Restore Yggdrasil builder compatibility with manifest v4 - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Rust target for pyrex41/yggdrasil#29 could not reach the model-checker fixture:
yggdrasil-buildon currentshen-rustmain failed to compile because itsCompileOptionsinitializer omittedseal_same_module. After that was supplied, the builder refused Yggdrasil's manifest v4.Change
seal_same_module: falsefor generated external modules, matchingCompileOptions::externaland preserving runtime rebinding.kernel,init,user, andfnfields from both.Verification
cargo build --release -p yggdrasil-buildpassed.8718c8c,scripts/parity-gate.sh --fixtures tla-election --targets rust --min-targets 1passed: build, golden comparison, and two-boot comparison.This unblocks the Rust target check for pyrex41/yggdrasil#29; it does not implement the separate native visited-map optimization.