Skip to content

Restore Yggdrasil builder compatibility with manifest v4 - #27

Merged
pyrex41 merged 1 commit into
mainfrom
fix/yggdrasil-builder-compile-options
Sep 27, 2026
Merged

pyrex41 merged 1 commit into
mainfrom
fix/yggdrasil-builder-compile-options

Conversation

@pyrex41

@pyrex41 pyrex41 commented Sep 27, 2026

Copy link
Copy Markdown
Owner

Why

The Rust target for pyrex41/yggdrasil#29 could not reach the model-checker fixture: yggdrasil-build on current shen-rust main failed to compile because its CompileOptions initializer omitted seal_same_module. After that was supplied, the builder refused Yggdrasil's manifest v4.

Change

  • Set seal_same_module: false for generated external modules, matching CompileOptions::external and preserving runtime rebinding.
  • Accept manifest v3 and v4. The parser already ignores unknown keys and reads the same kernel, init, user, and fn fields from both.

Verification

  • cargo build --release -p yggdrasil-build passed.
  • From Yggdrasil PR Update to Shen kernel 43.1 (S43) #30 at 8718c8c, scripts/parity-gate.sh --fixtures tla-election --targets rust --min-targets 1 passed: build, golden comparison, and two-boot comparison.

This unblocks the Rust target check for pyrex41/yggdrasil#29; it does not implement the separate native visited-map optimization.

@pyrex41
pyrex41 merged commit 33b1f52 into main Sep 27, 2026
2 checks passed
@pyrex41
pyrex41 deleted the fix/yggdrasil-builder-compile-options branch September 27, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant