Repository navigation
Fix Unicode handling in Shen string primitives - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
posindex Unicode scalar values instead of UTF-8 bytestlstrremove one complete Unicode scalar instead of slicing at byte 1string->nreturn the first scalar value, consistent withn->stringProblem
(tlstr "😀é")previously sliced the UTF-8 encoding after its first byte and failed withtlstr: produced non-UTF-8 result.posandstring->nused the same byte-oriented assumption, producing inconsistent behavior for multibyte text.Verification
cargo test -p shen-rust --test primitives_coverage string_ops string_op_errorscargo fmt --all -- --check(tlstr "😀é")=>"é"(string->n "😀")=>128512cargo test -p shen-rustrun was green through all reported library and initial AOT suites; the long-running command was interrupted after its output consumer detached.