Repository navigation
Fix, On Hover Docstring for Function Overloads - #5695
Open
dibrinsofor wants to merge 7 commits into
Open
dibrinsofor wants to merge 7 commits into
dibrinsofor wants to merge 7 commits into
Conversation
Signed-off-by: Dibri Nsofor <dibrinsofor@gmail.com>
Signed-off-by: Dibri Nsofor <dibrinsofor@gmail.com>
Signed-off-by: Dibri Nsofor <dibrinsofor@gmail.com>
Signed-off-by: Dibri Nsofor <dibrinsofor@gmail.com>
Signed-off-by: Dibri Nsofor <dibrinsofor@gmail.com>
Signed-off-by: Dibri Nsofor <dibrinsofor@gmail.com>
dibrinsofor
force-pushed
the
lsp-blame
branch
from
November 19, 2026 06:29
37ca683 to
b798361
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5647
Fix to track docstrings for overloaded functions and bounded methods on hover.
Uses the declaration from overload resolution to find the relevant docstring.
An earlier iteration attempted matching overload list by index, but that did not scale to meet bounded class methods.
Undocumented overloads fall back only to the overload implementation's docstring.
I am a human, and I fully understand the code I am submitting.
Test Plan
Tested hover coverage for overloaded functions and bounded class methods in
.../test/lsp/hover.rsfor int and str, and a bad case for an overload with no docstring.