Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyrefly/lib/alt/expr.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2865,7 +2865,7 @@ impl<'ctx, 'answer, Ans: LookupAnswer> AnswersSolver<'ctx, 'answer, Ans> {
}
} else if let Type::ClassType(cls) = ty {
let cls = cls.class_object();
if !self.is_subclassable(cls) && self.class_instances_always_truthy(cls) {
if self.class_instances_always_truthy(cls) {
return Some(true);
}
}
Expand Down
6 changes: 3 additions & 3 deletions pyrefly/lib/test/narrow.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4880,14 +4880,14 @@ def g(x: A | B | C) -> None:
testcase!(
test_class_may_be_falsy,
r#"
from typing import reveal_type
from typing import assert_type

class MyClass:
name: str

def myfn(x: MyClass | None):
# `x` could be a falsy instance of a subclass of `MyClass`
reveal_type(x and x.name) # E: (MyClass & Falsy) | str | None
# Like mypy and pyright, assume a subclass does not add `__bool__` or `__len__`.
assert_type(x and x.name, str | None)
"#,
);

Expand Down
Loading