Repository navigation
Conversation
Use explicit elided lifetime placeholders on the HintRef return type so the lifetime relationships are clear and the compiler warning is removed. Fixes pyrefly-org#5590.
This comment has been minimized.
This comment has been minimized.
|
Closing and reopening this PR to re-trigger CI, which was down over the weekend |
|
Hmm, I was hoping that would trigger the CLA bot to post, but no dice :( @jay23606 could you sign the Meta CLA (https://code.facebook.com/cla) so we can accept your PR? |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Merging this PR will not alter performance
Comparing Footnotes
|
|
I can't close or reopen this PR from my side, so I haven't changed anything for this request. A maintainer with access to the PR would need to re-trigger CI. |
|
@jay23606 What we need from you is a signed individual CLA: https://code.facebook.com/cla. |
|
Ah, it looks like the lifetime warning was already fixed sometime in the past few days: pyrefly/pyrefly/lib/alt/operators.rs Line 523 in 76655fa Sorry for all the back-and-forth and then not being able to merge this PR :( Getting the CLA signed is sometimes a bit of a chore, but now that we have it on file, you shouldn't need to sign it again for any subsequent PRs (to pyrefly or to any other Meta project) if you're still interested in contributing. |
Summary
Makes the lifetime parameters on
HintRefexplicit inas_hint_for_display, removing the inconsistent lifetime syntax warning from issue #5590.Fixes #5590
Test Plan
rustfmt --check pyrefly/lib/alt/operators.rs— passed.cargo check -p pyrefly— not completed locally; dependency fetching stalled. Draft CI is needed to confirm the compiler warning is gone.