Skip to content

Fix FPB literal comparator count decoding #2041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobertRostohar merged 1 commit into from
Oct 6, 2026
Merged

Fix FPB literal comparator count decoding #2041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions pyocd/coresight/fpb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# pyOCD debugger
# Copyright (c) 2015-2019 Arm Limited
# Copyright (c) 2015-2019,2026 Arm Limited
# Copyright (c) 2021 Chris Reed
# SPDX-License-Identifier: Apache-2.0
#
Expand Down Expand Up @@ -76,7 +76,7 @@ def init(self) -> None:
if self.fpb_rev not in (1, 2):
LOG.warning("Unknown FPB version %d", self.fpb_rev)
self.nb_code = ((fpcr >> 8) & 0x70) | ((fpcr >> 4) & 0xF)
self.nb_lit = (fpcr >> 7) & 0xf
self.nb_lit = (fpcr >> 8) & 0xf
LOG.info("%d hardware breakpoints, %d literal comparators", self.nb_code, self.nb_lit)
for i in range(self.nb_code):
self.hw_breakpoints.append(HardwareBreakpoint(self.address + FPB.FP_COMP0 + 4*i, self))
Expand Down Expand Up @@ -157,4 +157,3 @@ def remove_breakpoint(self, bp: Breakpoint) -> None:
self.ap.write_memory(hwbp.comp_register_addr, 0)
self.num_hw_breakpoint_used -= 1
return

Loading