Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of the existing
attributes_to_get, Scan.Select and Query.Select allows queries and scans against indexes with KEYS_ONLY and INCLUDE projections to read-through to the underlying table to fetch the entire model.P.S. Effectively the interesting mode of operation here is just
scan='ALL_ATTRIBUTES'for an index. Perhaps we shouldn't add it to Model.query/scan at all, while Index.query/scan should haveensure_all_attributes: boolwhich would trigger the behavior described here?