Conversation
saadmk11/changelog-ci@v1.2.0 builds FROM python:3.12-slim-bullseye. Bullseye is end-of-life and Debian is draining its package pool, so apt-get install git fails with exit code 100 and the workflow cannot build at all. Switch to mikepenz/release-changelog-builder-action, which builds no Docker image and is actively maintained, keep the same label groups, and grant the workflow the permissions the changelog commit and the pull request comment need. Re-runs are idempotent: a section that already exists for the version is replaced in place, and identical content produces no commit.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
=======================================
Coverage 90.16% 90.16%
=======================================
Files 24 24
Lines 1922 1922
=======================================
Hits 1733 1733
Misses 189 189 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Version-less release titles fail, and the workflow executes PR-controlled Python with write credentials.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Replaces the obsolete changelog action with maintained release automation.
Changes:
- Generates grouped release notes with a pinned action.
- Adds idempotent changelog insertion and PR commenting.
- Documents the updated release process.
| File | Description |
|---|---|
CONTRIBUTING.md |
Documents automated changelog generation. |
.gitignore |
Updates generated/config file rules. |
.github/workflows/changelog.yml |
Implements the new workflow. |
.github/scripts/update_changelog.py |
Inserts or replaces release sections. |
.github/changelog-config.json |
Defines changelog grouping and formatting. |
.github/changelog-ci-config.json |
Removes the obsolete configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cmanjah
left a comment
cmanjah
left a comment
There was a problem hiding this comment.
Could we add a few small tests for replace_section and drop_empty_groups? The update_changelog.py script has no tests.
| - name: Comment changelog on pull request | ||
| if: steps.version.outputs.version != '' && steps.commit.outputs.changed == 'true' | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| PR_NUMBER: ${{ github.event.pull_request.number }} | ||
| run: gh pr comment "$PR_NUMBER" --body-file .github/changelog.generated.md | ||
|
|
There was a problem hiding this comment.
If the push succeeds but commenting fails or the run is cancelled between them, the next run finds identical changelog content, sets changed=false, and skips commenting again.
Could we make comment creation independent of changed?
Description
saadmk11/changelog-ci@v1.2.0 builds FROM python:3.12-slim-bullseye. Bullseye is end-of-life and Debian is draining its package pool, so apt-get install git fails with exit code 100 and the workflow cannot build at all. Switch to mikepenz/release-changelog-builder-action, which builds no Docker image and is actively maintained, keep the same label groups, and grant the workflow the permissions the changelog commit and the pull request comment need.
Re-runs are idempotent: a section that already exists for the version is replaced in place, and identical content produces no commit.
Status
Ready
Types of changes
docsupdated.