Skip to content

Fix jensen_haise method 1 to use Ra * T / 40 instead of the McGuinness and Bordne form - #99

Open
rmz-oz wants to merge 1 commit into
pyet-org:devfrom
rmz-oz:fix-jensen-haise-method-1
Open

rmz-oz wants to merge 1 commit into
pyet-org:devfrom
rmz-oz:fix-jensen-haise-method-1

Conversation

@rmz-oz

@rmz-oz rmz-oz commented Oct 10, 2026

Copy link
Copy Markdown

Short Description

jensen_haise(method=1) computed ra * (tmean + 5) / 68 / lambd, which is the McGuinness and Bordne formula and gives the same numbers as mcguinness_bordne(k=1/68). This changes it to ra * tmean / 40 / lambd as in Oudin's thesis (p. 33, eq. 1.30, with McGuinness and Bordne right below as eq. 1.31) and fixes the docstring math to match.

The new test sits in tests/testalternative.py next to the other alternative methods. Note that plain pytest doesn't collect that file (the name doesn't match test_*.py), so CI doesn't run any of its tests; pytest tests/testalternative.py passes (10 tests).

Fixes #98

Checklist before PR can be merged:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant