Repository navigation
Sync with upstream and bump version to 0.54.3 #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adriangb
wants to merge
16
commits into
main
Choose a base branch
from
claude/release-version-prep-ii17k2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
3751908
Upgrade to DataFusion 53 (#107)
adriangb a3d9f62
Mark JSON-bearing string fields with is_json metadata (#111)
adriangb b2c3dc3
Also emit canonical Arrow JSON extension metadata keys (#112)
adriangb 0290f01
Bump version to 0.53.1 (#113)
adriangb 5a2550f
Add json_union_to_text UDF to flatten a JSON union to JSON text (#114)
adriangb 62208b0
Mark json_union_to_text output as the canonical Arrow JSON extension …
adriangb e8a1a37
Add string type coercions for primitive values (#110)
cetra3 086b3f9
Prepare for DataFusion 54 (#109)
adriangb 1a4450c
Bump version to 0.54.0 in Cargo.toml (#116)
adriangb 7c3d528
Bump version to 0.54.1 and update jiter to 0.15 (#117)
adriangb aad1d7f
ci: pin GitHub Actions to latest versions by commit SHA (#118)
adriangb 88e4865
Fix Null Arrays as Input (#119)
cetra3 d13d553
Bump version to 0.54.2 (#120)
adriangb 2d7a86f
Fix nested JSON string access (#121)
friendlymatthew 774c570
Fix panic on JSON integers outside the i64 fast path (#124)
adriangb 42658c1
Bump version to 0.54.3
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| /target | ||
| Cargo.lock | ||
| .idea | ||
| .history |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Medium
src/common_union.rs:184Unions produced by previous releases are no longer recognized as JSON unions. The code identifies a union by comparing the full
UnionFieldsfor equality, andunion_fields()now addsARROW:extension:nameandARROW:extension:metadatakeys to thearrayandobjectchild fields. Existing unions whose child fields carry only the legacyis_json=truemetadata fail this equality check, so passing them intoJsonUnionEncoder::from_unionorjson_union_to_textis rejected as a non-JSON union — even though the legacyis_jsonkey was explicitly retained for backward compatibility. Recognition should accept both the legacy and canonical metadata shapes (e.g., ignore these additive metadata keys when identifying the union type), not require an exact match.🚀 Reply "fix it for me" or copy this AI Prompt for your agent: