Repository navigation
Run the batch operations of S3FileSystem concurrently (GH-1322) #1344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b9203e5
Run the batch operations of S3FileSystem concurrently (GH-1322)
laughingman7743 d26a158
Address the independent review of the batch operations (GH-1322)
laughingman7743 ee97456
Pass on the callback that a branch enters (GH-1322)
laughingman7743 ed4f431
Assert the late copy of the mv failure test (GH-1322)
laughingman7743 fb082b3
Accept the lookup parameters in the stub of the skipped-prefix copy t…
laughingman7743 eaa1441
Move one object at a time in the stubbed source-parameter test of mv …
laughingman7743 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-review round 2 (claims, compatibility, operations) — base
7fcbcc64b02f9a5efe16ec04815b4143d1a2c615, head24d9872ff4026dc67e6d9bd63fed6080fe11b120.Claims checked against the code:
cat_fileand the smallpipe_filesend their request from the task thread (sobatch_size > max_workersraises total concurrency — documented);mvdeletes only aftermapreturns; a committed multipart copy still copies its annotations underunstoppable_retries(); the conflict rules matchS3PathPairing._check(self-copy kept, prefix-only skips excluded, same existing file byst_dev/st_ino, file-like by identity);rm(max_workers=)warns withstacklevel=2.Existing callers: positional arguments of
S3FileSystem.__init__unchanged (batch_sizeis keyword-only after*args);AioS3FileSystemkeeps its ownbatch_sizeand does not pass it to the internal filesystem;AioS3FileSystem._mvstill uses_move_pairs, whose return is unchanged; norm(max_workers=)call inpyathena/orbenchmarks/.Operational: a stopped
stop_retries_on()scope now also makes S3 reads and writes raiseCancelledErrorbefore their next request (release note in the PR body). The design comment saidretry_api_callandwait_with_retry_stopwould reuse the new test; they keep their own snapshot of the events, which is equivalent, so that sentence is not implemented and is not claimed in the PR.Evidence: local AWS filesystem suite 1549 passed (implementation of
24d9872f); AWS CI not run yet (Draft). CLEAN.