Skip to content

Remove the AioPandasCursor tests that #1245 covers #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laughingman7743 merged 1 commit into from
Oct 18, 2026
Merged

Remove the AioPandasCursor tests that #1245 covers #1265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions tests/pyathena/aio/pandas/test_cursor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,16 +64,6 @@ async def test_no_result_set_raises(self, aio_pandas_cursor):
with pytest.raises(ProgrammingError):
aio_pandas_cursor.as_pandas()

async def test_invalid_arraysize(self, aio_pandas_cursor):
aio_pandas_cursor.arraysize = 10000
assert aio_pandas_cursor.arraysize == 10000
with pytest.raises(ProgrammingError):
aio_pandas_cursor.arraysize = -1

async def test_cancel_initial(self, aio_pandas_cursor):
with pytest.raises(ProgrammingError):
await aio_pandas_cursor.cancel()

@pytest.mark.parametrize(

@laughingman7743 laughingman7743 Oct 18, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review of fb22d08a432f120a187d23a07e0e84652e7abc92..d0889525ee0a1dfff0cfc5a8a06054c7bead7607.

Round 1 (behavior and test quality): CLEAN. AioPandasCursor inherits arraysize from WithResultSet, whose constructor assigns through the setter (pyathena/result_set.py:1013), so the constructor-based covers reach the setter that test_invalid_arraysize assigned; capping it at 1000 or accepting zero fails the AioPandasCursor cases. cancel() is WithAsyncFetch.cancel(), shared by the aio cursors; removing its query ID check fails test_cancel_without_query[AioPandasCursor]. ProgrammingError and pytest stay in use; just lint passed.

Round 2 (claims and operation): CLEAN. The covers exist on fb22d08 with AioPandasCursor in UNCAPPED_CURSORS (tests/pyathena/test_connection.py:52) and _ALL_CURSOR_CLASSES (tests/pyathena/aio/test_common.py:23). The removed tests used the live aio_pandas_cursor fixture, so the change saves its connection setup; no local live run.

@laughingman7743 laughingman7743 Oct 18, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review (relayed): Codex CLI 0.163.0, model gpt-6-astra, ChatGPT login, codex exec -s read-only, session 01a14c93-e754-7441-92bb-230bd3e6689a. Static review of fb22d08a..d0889525 in a clean detached snapshot, with the diff and the test policy, and no PR text or author findings. Result: CLEAN.

Covered: the cursor sources, inheritance, constructor and factory paths, fixtures, and the remaining tests under tests/pyathena/. It found that the WithResultSet.arraysize setter (pyathena/result_set.py:1328) is also checked by pandas/test_cursor.py::TestPandasCursor::test_invalid_arraysize and by the offline connection tests with AioPandasCursor, and that test_cancel_without_query[AioPandasCursor] awaits the real cancel(), so replacing its ProgrammingError (pyathena/aio/common.py:788) fails it.

"aio_pandas_cursor",
[{"cursor_kwargs": {"unload": True}}],
Expand Down
Loading