Skip to content

Keep 3.x releases from becoming the latest GitHub release #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laughingman7743 merged 1 commit into from
Oct 16, 2026
Merged

Keep 3.x releases from becoming the latest GitHub release #1210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,5 @@ jobs:
dist/*.whl
dist/*.tar.gz
generate_release_notes: true
# A release of this maintenance line does not replace the latest release of master.

@laughingman7743 laughingman7743 Oct 16, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review round two (claims, operations): CLEAN.

  • PR body claims: the action's input contract and value handling are checked above. v3.40.0 was marked Latest after its publish and v4.1.0 was restored with gh release edit v4.1.0 --latest (gh release list before and after). Master's release.yaml is unchanged and keeps the default.
  • Operations: the effect shows only at the next 3.x tag; the PR body says to check gh release list then. A 3.x release can still be made Latest by hand if ever needed.
  • Docs: no repository doc or skill mentions make_latest or the Latest marker, so nothing else needs updating.

make_latest: false

@laughingman7743 laughingman7743 Oct 16, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review round one (implementation behavior): CLEAN.

Scope: base 7fb102a, head 44f10a0; the single changed step.

  • The pinned action (153bb8e0, v2.6.1) reads INPUT_MAKE_LATEST through parseMakeLatest() (src/util.ts:120) and passes it to both the create and the update release calls (src/github.ts:192, :586). A YAML false reaches it as the string false, which it accepts; anything other than true/false/legacy would be dropped to the API default.
  • Only the Release step creates a GitHub release on 3.x, so every 3.x release is covered; PyPI publishing and the test gate are untouched.
  • Pre-existing, out of scope: actionlint reports matrix.python-version without a matrix at line 36 (already known; harmless).

@laughingman7743 laughingman7743 Oct 16, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review (relayed): Codex CLI 0.162.1, model gpt-6-astra, reasoning effort max, codex exec -s read-only, session 01a1455a-8674-7e02-bdff-508016f1c2c4. Static review only (the action's input semantics were assessed from the reviewer's knowledge; no network). Snapshot: detached worktree at 44f10a0; range 7fb102a..44f10a0; prompt without the PR number, description, or prior findings.

Result: CLEAN.

Covered: the diff, tag trigger, release creation, action input handling, PyPI publishing, artifacts, generated notes, and the reusable test gate. make_latest: false applies unconditionally to the sole GitHub release step, so every release created by this workflow revision receives it. GitHub Actions passes the unquoted YAML boolean as the string "false", which the pinned action accepts. Build, PyPI publishing, asset uploads, generate_release_notes, and needs: test are unchanged.

The author verified the input handling against the pinned action's source (round one). The independent review of this PR is complete.

Loading