Skip to content

Review the PyHive-derived DB API tests repeated for each cursor class #1260

Closed

Description

@laughingman7743

Summary

Part of #1239. Review the tests that follow PyHive's DB API and SQLAlchemy test cases and that are repeated for each cursor class, against "Choose what to test" in docs/testing.md. The audit in #1239 kept them as original tests. Update NOTICE, which still names a PyHive-derived test that #1251 removed.

Facts (origin/master 193d23b, 2026-10-18)

Proposed change

  1. Update NOTICE for the tests that remain at the time of the change. This includes the removed aio test_unicode, and any PyHive-derived test that item 2 removes or moves.
  2. For each copied test, name the code path it exercises: the result set class and its fetch implementation, the read path (UNLOAD or CSV), and the sync, async, or aio cursor. Keep one test per distinct path, and remove or merge copies that run through the same code with the same kind of evidence.
  3. Keep the queries that the remaining tests run to what their contracts need.

Order

After #1252, #1253, #1256, and #1258 merge. They change the same files, so this sub-issue starts from the tests they leave. Item 1 can land first.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions