You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Build the pandas result-set tests through the constructor #1257
_read_csv_result(), _unload_result_set(), and _read_unload_result() predate Remove and rewrite unnecessary pandas cursor tests #1256. They create the instance with __new__, set about ten private attributes, and patch private methods and properties (description, output_location, _get_content_length, _read_data_manifest, is_unload).
The second kind tests a result set that __init__ never builds. A change to the constructor's state, such as a new attribute that the reads use, can pass these tests and fail for callers. Two helpers also give future tests a choice of fakes; #1256's reviews asked to keep a single kind.
Proposal
Move the tests that use the bypass helpers onto _local_result_set(), mainly the json-column tests and test_iter_parquet_chunks_null_in_later_file, then delete the bypass helpers. Each moved test must still fail under its mutation. Some json tests read CSV text that is not quoted as Athena writes it; check that they read the same data through the constructor. _fetching_result_set() patches _create_dataframe_iterator to feed prepared chunks and can stay, because the fetch tests need chunk boundaries that a local file does not control.
From the review of #1256: no test checks that a cursor's block_size and cache_type reach PyAthena's S3FileSystem for the CSV result file (pyathena/pandas/result_set.py:869-870). The local filesystem of _local_result_set() ignores construction options, so a test of this needs PyAthena's real S3FileSystem over a stubbed S3 client, with nondefault settings.
Activity
laughingman7743 commentedon Oct 17, 2026
From the review of #1256: no test checks that a cursor's
block_sizeandcache_typereach PyAthena'sS3FileSystemfor the CSV result file (pyathena/pandas/result_set.py:869-870). The local filesystem of_local_result_set()ignores construction options, so a test of this needs PyAthena's realS3FileSystemover a stubbed S3 client, with nondefault settings.Restore the checks that the move to the constructor dropped
Check that chunked UNLOAD reads do not list the unload location