You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Move the write-and-close helpers from S3FileSystem to S3File #1034
Neither uses the filesystem. Both operate only on the S3File they receive, and call its private _close_without_commit() from outside the class. AioS3FileSystem does not inherit S3FileSystem, so it reaches them through its internal filesystem (self._sync_fs._write_and_close(...), self._sync_fs._write_file_and_close(...)), although AioS3File inherits S3File.
Proposed change
Move both helpers to S3File as instance methods, next to _close_without_commit(), and call them on the opened file:
Activity
Move the write-and-close helpers from S3FileSystem to S3File