Fix ToUnicode CMaps exceeding the 100-entry bfchar block limit - #1954
Merged
Merged
Conversation
jbarlow83
added a commit
to ocrmypdf/OCRmyPDF
that referenced
this pull request
Sep 16, 2026
Upstream fpdf2 merged py-pdf/fpdf2#1954, which splits ToUnicode bfchar blocks to 100 entries, but the Encoding CMap it writes for CFF CID-keyed fonts (such as Noto Sans CJK OpenType) is still one cidchar block. Ghostscript 9.56 through 10.04 drop it, and then both draw the wrong glyphs and extract garbage. Verified against fpdf2 master and Ghostscript 10.02.1. Document that the patch stays in place for every fpdf2 release, and add a subset of Noto Sans CJK JP as a test resource so the cidchar path is covered, including a Ghostscript round trip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1952
Checklist:
A unit test is covering the code added / modified by this PR
A mention of the change is present in
CHANGELOG.mdThis PR is ready to be merged
By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.