Skip to content

Fix typographical error in Klucher's transposition model equation#930

Merged
CameronTStark merged 1 commit into
pvlib:masterfrom
modiprabal:fix-Klucher-eqn
Mar 12, 2020
Merged

Fix typographical error in Klucher's transposition model equation#930
CameronTStark merged 1 commit into
pvlib:masterfrom
modiprabal:fix-Klucher-eqn

Conversation

@modiprabal

Copy link
Copy Markdown
Contributor
  • Closes Error on Klucher's transposition model equation #923
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.
These changes fix the typographical error in Klucher's transposition model equation where the transposition factor was missing an exponent of 2.

@mikofski mikofski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

thanks!

@CameronTStark CameronTStark self-requested a review March 12, 2020 13:48

@CameronTStark CameronTStark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @modiprabal for your contribution!

@CameronTStark CameronTStark merged commit 7274e0a into pvlib:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error on Klucher's transposition model equation

4 participants