Deprecate and disable data_version parameter in get_meteonorm_tmy#2781
Conversation
|
The change is documented in the meteonorm changelog: https://docs.meteonorm.com/overview/changelog-api#2025-12-05 |
|
We can deprecate this with a message "this parameter no longer has any effect (see XX meteonorm URL) and will be removed soon", right? Can we do that instead of jumping straight to removal? |
The issue is that the API requests are currently failing when the parameter is included. |
|
Right. Can't we keep it as a parameter to the pvlib function (to avoid a breaking change), and just stop including it in the API request? |
kandersolar
left a comment
There was a problem hiding this comment.
Here are the changes I'm suggesting. Ideally there would also be a test to verify the deprecation warning.
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
echedey-ls
left a comment
There was a problem hiding this comment.
LGTM, minor whatsnew nitpick down below. I'll add this change to #2396.
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
|
Test failure unrelated |
data_version parameter in get_meteonorm_tmy
docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.The remote data tests are currently failing due to the
get_meteonorm_tmyfunction no longer supporting thedata_versionparameter.