Skip to content

Deprecate and disable data_version parameter in get_meteonorm_tmy#2781

Merged
kandersolar merged 11 commits into
pvlib:mainfrom
AdamRJensen:meteonorm-test-data_version
Jun 16, 2026
Merged

Deprecate and disable data_version parameter in get_meteonorm_tmy#2781
kandersolar merged 11 commits into
pvlib:mainfrom
AdamRJensen:meteonorm-test-data_version

Conversation

@AdamRJensen

Copy link
Copy Markdown
Member
  • I am familiar with the contributing guidelines
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license
  • Tests added
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

The remote data tests are currently failing due to the get_meteonorm_tmy function no longer supporting the data_version parameter.

@AdamRJensen AdamRJensen added this to the v0.15.2 milestone Jun 10, 2026
@AdamRJensen AdamRJensen added bug io remote-data triggers --remote-data pytests labels Jun 10, 2026
@AdamRJensen AdamRJensen changed the title Meteonorm test data version Remove data_version parameter from get_meteonorm_tmy Jun 10, 2026
@AdamRJensen AdamRJensen added remote-data triggers --remote-data pytests and removed remote-data triggers --remote-data pytests labels Jun 10, 2026
@AdamRJensen

Copy link
Copy Markdown
Member Author

The change is documented in the meteonorm changelog: https://docs.meteonorm.com/overview/changelog-api#2025-12-05

@kandersolar

Copy link
Copy Markdown
Member

We can deprecate this with a message "this parameter no longer has any effect (see XX meteonorm URL) and will be removed soon", right? Can we do that instead of jumping straight to removal?

@AdamRJensen

Copy link
Copy Markdown
Member Author

We can deprecate this with a message "this parameter no longer has any effect (see XX meteonorm URL) and will be removed soon", right? Can we do that instead of jumping straight to removal?

The issue is that the API requests are currently failing when the parameter is included.

@kandersolar

Copy link
Copy Markdown
Member

Right. Can't we keep it as a parameter to the pvlib function (to avoid a breaking change), and just stop including it in the API request?

@kandersolar kandersolar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the changes I'm suggesting. Ideally there would also be a test to verify the deprecation warning.

Comment thread pvlib/iotools/meteonorm.py Outdated
Comment thread pvlib/iotools/meteonorm.py
Comment thread pvlib/iotools/meteonorm.py
@AdamRJensen AdamRJensen added remote-data triggers --remote-data pytests and removed remote-data triggers --remote-data pytests labels Jun 15, 2026
Comment thread docs/sphinx/source/whatsnew/v0.15.2.rst Outdated
Comment thread tests/iotools/test_meteonorm.py Outdated
AdamRJensen and others added 2 commits June 16, 2026 10:42
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>

@echedey-ls echedey-ls left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor whatsnew nitpick down below. I'll add this change to #2396.

Comment thread docs/sphinx/source/whatsnew/v0.15.2.rst Outdated
@echedey-ls echedey-ls added the deprecation Use for issues and PRs which involve deprecations label Jun 16, 2026
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
@kandersolar

Copy link
Copy Markdown
Member

Test failure unrelated

@kandersolar kandersolar changed the title Remove data_version parameter from get_meteonorm_tmy Deprecate and disable data_version parameter in get_meteonorm_tmy Jun 16, 2026
@kandersolar kandersolar merged commit 1f90861 into pvlib:main Jun 16, 2026
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug deprecation Use for issues and PRs which involve deprecations io remote-data triggers --remote-data pytests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants