Skip to content

Correct ERA5 timestamp convention#2773

Merged
AdamRJensen merged 3 commits into
pvlib:mainfrom
AdamRJensen:update-era5-timestamp-convention
Jun 8, 2026
Merged

Correct ERA5 timestamp convention#2773
AdamRJensen merged 3 commits into
pvlib:mainfrom
AdamRJensen:update-era5-timestamp-convention

Conversation

@AdamRJensen

Copy link
Copy Markdown
Member
  • Closes Incorrect timestamp index description in iotools.era5 docstring #2772
  • I am familiar with the contributing guidelines
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

See discussion in #2772.

@AdamRJensen AdamRJensen added this to the v0.15.2 milestone Jun 2, 2026
@AdamRJensen AdamRJensen changed the title Correct era5 timestamp convention Correct ERA5 timestamp convention Jun 2, 2026

@echedey-ls echedey-ls left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'd call it a bugfix thou, also cause it probably draws more attention.

Comment thread docs/sphinx/source/whatsnew/v0.15.2.rst Outdated
* Clarifies how Linke turbidity values can be provided to
:py:func:`pvlib.clearsky.ineichen` via
:py:func:`pvlib.clearsky.lookup_linke_turbidity` (:issue:`2598`, :pull:`2746`)
* Documented that timestamps returned by :py:func:`~pvlib.iotools.get_era5`

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Documented that timestamps returned by :py:func:`~pvlib.iotools.get_era5`
* Document that timestamps returned by :py:func:`~pvlib.iotools.get_era5`

@AdamRJensen AdamRJensen merged commit ba4c7c5 into pvlib:main Jun 8, 2026
31 checks passed
@AdamRJensen AdamRJensen deleted the update-era5-timestamp-convention branch June 8, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect timestamp index description in iotools.era5 docstring

2 participants