Skip to content

correct keys for FS modules in spectrum.spectral_factor_pvspec#2400

Merged
cwhanse merged 4 commits into
pvlib:mainfrom
RDaxini:pvspec_keys
Feb 26, 2025
Merged

correct keys for FS modules in spectrum.spectral_factor_pvspec#2400
cwhanse merged 4 commits into
pvlib:mainfrom
RDaxini:pvspec_keys

Conversation

@RDaxini

@RDaxini RDaxini commented Feb 25, 2025

Copy link
Copy Markdown
Member
  • Closes PVSPEC model coefficients for First Solar modules use wrong keys #2398
  • I am familiar with the contributing guidelines
  • Tests added
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@RDaxini RDaxini changed the title correct keys correct keys for FS modules in spectrum.spectral_factor_pvspec Feb 25, 2025
@RDaxini RDaxini added this to the v0.11.3 milestone Feb 25, 2025
@RDaxini RDaxini marked this pull request as draft February 25, 2025 23:06
@RDaxini RDaxini marked this pull request as ready for review February 25, 2025 23:09

@IoannisSifnaios IoannisSifnaios left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edit, maybe add the word "series" in the fs4-2 description:
image

@cwhanse cwhanse merged commit 5c86e8c into pvlib:main Feb 26, 2025
@cwhanse

cwhanse commented Feb 26, 2025

Copy link
Copy Markdown
Member

Thanks @RDaxini

@RDaxini RDaxini deleted the pvspec_keys branch February 26, 2025 23:59
@kandersolar kandersolar modified the milestones: v0.11.3, v0.12.0 Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PVSPEC model coefficients for First Solar modules use wrong keys

4 participants