Updating Townsends snow model references#2384
Conversation
ayushjariyal
commented
Feb 9, 2025
ayushjariyal
commented
- Closes loss_townsend: Update Townsend Snow Model References #2383
cwhanse
left a comment
cwhanse
left a comment
There was a problem hiding this comment.
@ayushjariyal you will need to fix the line length and indentation in reference [2]
Please add a note to the whatsnew file for v0.11.3
cwhanse
left a comment
cwhanse
left a comment
There was a problem hiding this comment.
You can add a line after this one in the whatsnew file
* Manoj K S (:ghuser:`manojks1999`)
|
@ayushjariyal can you fix the line length issues in your editor? I'm having difficulty suggesting corrections here. |
ayushjariyal
force-pushed
the
issue_2383
branch
from
af253e3 to
7d699c8
Compare
|
@cwhanse I’m having trouble understanding why the tests are failing.
Could you please help clarify the issue? |
You can ignore those failures. They are unrelated to the changes you made and they are happening in other PRs. |
|
Thank you for the clarification! |
IoannisSifnaios
left a comment
IoannisSifnaios
left a comment
There was a problem hiding this comment.
LGTM! Only one suggestion from my side.
| .. [3] Townsend, T. (2025). Snow Events Definition. | ||
| :doi:`10.13140/RG.2.2.14299.68647` |
There was a problem hiding this comment.
I suggest we use the actual title of the poster and also mention that it was presented in SPI conference in 2013 (see info in the image below)
There was a problem hiding this comment.
I agree - I overlooked the "SPI 2013" conference label. Reference text should be
[3] Townsend, T. (2013). Predicting PV Energy Loss Caused by Snow. Solar Power International, Chicago IL. :doi:10.13140/RG.2.2.14299.68647
| Available at: https://www.nrel.gov/docs/fy25osti/90585.pdf | ||
| .. [3] Townsend, T. (2013). Predicting PV Energy Loss Caused by Snow. | ||
| Solar Power International, Chicago IL. | ||
| doi:`10.13140/RG.2.2.14299.68647` |
There was a problem hiding this comment.
| doi:`10.13140/RG.2.2.14299.68647` | |
| :doi:`10.13140/RG.2.2.14299.68647` |
One last edit I think.
|
Thanks @ayushjariyal ! |
|
@cwhanse Thank you for reviewing and merging my PR! I really appreciate the support. Also, does this organization participate in GSoC? I'm excited to contribute further! |
|
@ayushjariyal we do participate in GSoC, the current list of project ideas is here. |
* Updating Townsends snow model references * Applying reviews * Adding a note to the whatsnew file for v0.11.3 * Applying review * Add myself as contributor and apply reviews * Fix the line length issue * Adding actual title of the poster * correct doi syntax
4 participants
