Fix for the different results for Procedural and Object oriented exam…#2367
Merged
Conversation
Member
|
@manojks1999 please add a line to the whatsnew file for v0.11.3 at /docs/sphinx/source/whatsnew, and your name/GH to the Contributors list. |
Contributor
Author
|
Hi @cwhanse , |
echedey-ls
reviewed
Jan 30, 2025
echedey-ls
left a comment
echedey-ls
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR @manojks1999 !! Minor comments down below.
| ~~~~~~~~~~~~ | ||
| * Rajiv Daxini (:ghuser:`RDaxini`) | ||
| * Mark Campanelli (:ghuser:`markcampanelli`) | ||
| * Manoj K S (:ghuser: `manojks1999`) |
Member
There was a problem hiding this comment.
Suggested change
| * Manoj K S (:ghuser: `manojks1999`) | |
| * Manoj K S (:ghuser:`manojks1999`) |
| Documentation | ||
| ~~~~~~~~~~~~~ | ||
|
|
||
| * :py:meth:`~pvlib.solarposition.get_solarposition` Changes for different results for Procedural and Object oriented examples |
Member
There was a problem hiding this comment.
Suggested change
| * :py:meth:`~pvlib.solarposition.get_solarposition` Changes for different results for Procedural and Object oriented examples | |
| * Fix Procedural and Object Oriented simulation examples having slightly different results, in :ref:`introtutorial`. |
cwhanse
approved these changes
Jan 30, 2025
cwhanse
left a comment
cwhanse
left a comment
Member
There was a problem hiding this comment.
Approve with changes recommended by @echedey-ls
Contributor
Author
|
@cwhanse , done with the changes |
Member
|
Thanks @manojks1999 |
echedey-ls
pushed a commit
to echedey-ls/pvlib-python
that referenced
this pull request
Feb 19, 2025
pvlib#2367) * Fix for the different results for Procedural and Object oriented examples * Updated the docs * Change in docs --------- Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ples
[ ] Tests addedremote-data) and Milestone are assigned to the Pull Request and linked Issue.