Skip to content

Fix Windows/Conda CI error in test_singlediode.py#2007

Merged
kandersolar merged 5 commits into
pvlib:mainfrom
echedey-ls:fix-conda-errors-pls
Apr 15, 2024
Merged

Fix Windows/Conda CI error in test_singlediode.py#2007
kandersolar merged 5 commits into
pvlib:mainfrom
echedey-ls:fix-conda-errors-pls

Conversation

@echedey-ls

@echedey-ls echedey-ls commented Apr 12, 2024

Copy link
Copy Markdown
Member

Fixes the Windows-conda error by mocking the platform-variadic _lambert_v_from_i .

No need for a whatsnew entry I believe.

@echedey-ls echedey-ls changed the title [WAITING FOR CI TO FINISH] Fix Windows/Conda CI error in test_singlediode.py Fix Windows/Conda CI error in test_singlediode.py Apr 12, 2024
@echedey-ls echedey-ls marked this pull request as ready for review April 12, 2024 19:11
@cwhanse

cwhanse commented Apr 12, 2024

Copy link
Copy Markdown
Member

@kandersolar I'm OK with this.

@kandersolar kandersolar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution. Thanks @echedey-ls!

@kandersolar kandersolar merged commit c2ac022 into pvlib:main Apr 15, 2024
@echedey-ls echedey-ls deleted the fix-conda-errors-pls branch April 15, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Variance in scipy.special.lambertw output depending on scipy version and installation source

3 participants