Correct slope calculation in clearsky.detect_clearsky#1242
Merged
Conversation
kandersolar
reviewed
Jun 17, 2021
kandersolar
left a comment
kandersolar
left a comment
Member
There was a problem hiding this comment.
I think this bug affected 0.8.1 so this needs a whatsnew entry, right?
kandersolar
reviewed
Jun 17, 2021
| def _slope_nstd_windowed(data, H, samples_per_window, sample_interval): | ||
| with np.errstate(divide='ignore', invalid='ignore'): | ||
| raw = np.diff(data) | ||
| raw = np.diff(data) / sample_interval |
Member
There was a problem hiding this comment.
Somehow I failed to include this comment earlier: is raw here equivalent to data_slope.values[:-1]? If so there might be some modest speedup to be had by passing that in to avoid calculating slope twice.
wholmgren
approved these changes
Jun 25, 2021
Member
|
Thanks @cwhanse |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates entries todocs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).Adds a test with time interval of 2 minutes.