Revise modelchain.rst for multiple arrays, results attribute#1223
Conversation
cwhanse
changed the title
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| The PVSystem can represent a PV system with a single array of modules, or | ||
| with [multiple arrays](#PVSystem and Arrays). The same models are applied to |
There was a problem hiding this comment.
Anyone know how to link to a heading in a different file (pvsystem.rst, in this case)?
There was a problem hiding this comment.
wholmgren
left a comment
wholmgren
left a comment
There was a problem hiding this comment.
thanks for the careful edits
|
Haven't looked at the new text yet, but I did quickly scroll through the log on the last RTD build and it looks like |
I will search the rest of the doc files. |
kandersolar
left a comment
kandersolar
left a comment
There was a problem hiding this comment.
Mostly nitpicks about sphinx output
| logic to assign one of the model-specific methods, such as | ||
| :py:meth:`~pvlib.modelchain.ModelChain.sapm` or :py:meth:`~pvlib.modelchain.ModelChain.snlinverter`, | ||
| to the universal method names ``ModelChain.dc_model`` and ``ModelChain.ac_model``, | ||
| respectively. A few examples are shown below. Inferrence methods generally work |
There was a problem hiding this comment.
this suggestion might have been buried/overlooked.
|
Builds clean on my machine. I say merge it now. We'll need a doc clean up PR for a few unrelated problems. |
|
ready to merge @cwhanse? |
|
Yes, ready. |
3 participants
Tests addedUpdates entries todocs/sphinx/source/api.rstfor API changes.Adds description and name entries in the appropriate "what's new" file indocs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.