Propagate parameters on calcparams_cec call (#1215)#1216
Conversation
|
For testing pass-through arguments we typically use the The failing tests are unrelated; looks like the PVGIS copyright text just changed again. |
|
@kanderso-nrel Thanks! I also added a comment in #776, since I think lint checks could help preventing these types of errors. 😊 |
|
New/better test would be great but optional since this is straightforward and I'm not too concerned about a regression. Definitely should note it in the whats new file. |
|
@kanderso-nrel @wholmgren @cwhanse Added test and a short line in whatsnew. Thanks for your feedback! 😊 👍 |
388dffa to
8a8a659
Compare
|
I'll have a look at Python 3.6 and 3.7 failures! |
|
Should be fixed now. 😊 |
kandersolar
left a comment
There was a problem hiding this comment.
Thanks and good catch @Peque!
Remove mistaken text
|
can this be merged? |
pvsystem.calcparams_cec()does not propagate parameters #1215Updates entries todocs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.Not sure if tests are required (if so, which tests would be appropriate?). Not sure if an update to "whatsnew" is required.