Add missing modules to init.py#1103
Merged
Merged
Conversation
Member
|
Ah good catch @kanderso-nrel. Putting the imports in alphabetical order would make it easier to catch missing modules. While you're at it, I think this pattern might be more concise: from pvlib import ( # noqa: F401
shading,
snow,
) |
wholmgren
approved these changes
Dec 8, 2020
Member
|
ignoring psm3 failures and merging... thanks @kanderso-nrel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #xxxxTests addedUpdates entries todocs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.__init__.pyis missing several modules. Some of the omissions don't make a practical difference, maybe because they get imported by other modules. Forshadingandscaling, some import patterns fail:I think I got all the missing modules but another pair of eyes never hurts.