Skip to content

Verify weather includes 'dhi' in ModelChain.prepare_inputs()#1093

Merged
wholmgren merged 3 commits into
pvlib:masterfrom
wfvining:issue1092
Nov 23, 2020
Merged

Verify weather includes 'dhi' in ModelChain.prepare_inputs()#1093
wholmgren merged 3 commits into
pvlib:masterfrom
wfvining:issue1092

Conversation

@wfvining

@wfvining wfvining commented Nov 20, 2020

Copy link
Copy Markdown
Contributor
  • Closes ModelChain.prepare_inputs can succeed with missing dhi #1092
  • I am familiar with the contributing guidelines
  • Tests added
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

@wholmgren wholmgren added this to the 0.8.1 milestone Nov 21, 2020
@wholmgren wholmgren added the bug label Nov 21, 2020
@wfvining

wfvining commented Nov 23, 2020

Copy link
Copy Markdown
Contributor Author

I think this is ready for review, but I'm not sure what that test failure is about. It is from test_get_psm3_5min, which should be completely unaffected by this PR (doesn't look like the test interacts with ModelChain at all).

@cwhanse

cwhanse commented Nov 23, 2020

Copy link
Copy Markdown
Member

Test failure is due to #1091

@wholmgren wholmgren left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wfvining. I suggest we go ahead and merge.

@wfvining

Copy link
Copy Markdown
Contributor Author

Thanks @cwhanse. I suspected it might be something like that.

@wholmgren wholmgren merged commit 1024194 into pvlib:master Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ModelChain.prepare_inputs can succeed with missing dhi

3 participants