Skip to content

add Ross temperature model#1045

Merged
wholmgren merged 9 commits into
pvlib:masterfrom
cwhanse:temp_ross
Oct 9, 2020
Merged

add Ross temperature model#1045
wholmgren merged 9 commits into
pvlib:masterfrom
cwhanse:temp_ross

Conversation

@cwhanse

@cwhanse cwhanse commented Sep 4, 2020

Copy link
Copy Markdown
Member
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

A simple cell temperature model using only NOCT as a parameter.

Comment thread pvlib/temperature.py Outdated
Comment thread pvlib/temperature.py Outdated
Comment thread pvlib/temperature.py Outdated
Comment thread pvlib/temperature.py Outdated
Comment thread pvlib/temperature.py Outdated
Comment thread docs/sphinx/source/whatsnew/v0.8.0.rst Outdated
@cwhanse cwhanse added this to the 0.8.1 milestone Sep 21, 2020

@kandersolar kandersolar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wholmgren wholmgren left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Minor stuff below.

Comment thread docs/sphinx/source/api.rst
Comment thread docs/sphinx/source/whatsnew/v0.8.1.rst
Comment thread pvlib/temperature.py Outdated
Comment thread pvlib/temperature.py Outdated
Comment thread pvlib/temperature.py Outdated
Comment thread pvlib/temperature.py Outdated
@adriesse

Copy link
Copy Markdown
Member

Should this really be called a "Ross" model? It's just basic heat loss and NOCT conditions:

total_loss_factor  = 800 / (noct - 20)
heat_input = poa_global
temp_difference = heat_input / total_loss_factor
return temp_air + temp_difference

I wouldn't say this approach ignores the effect of wind but rather that it tacitly assumes a wind speed of 1 m/s.

@cwhanse

cwhanse commented Sep 23, 2020

Copy link
Copy Markdown
Member Author

Should this really be called a "Ross" model? It's just basic heat loss and NOCT conditions:

Agree that's what it is, but it needs a name, and others have cited it as Ross' model (author of the reference).

I wouldn't say this approach ignores the effect of wind but rather that it tacitly assumes a wind speed of 1 m/s.

good point.

@cwhanse cwhanse left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change docstring

Comment thread pvlib/temperature.py Outdated
@wholmgren

Copy link
Copy Markdown
Member

thanks @cwhanse!

@wholmgren wholmgren merged commit b105021 into pvlib:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants